feat(commerce): allow for locale-specific product name patterns #3657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Introduces localized product-name patterns across the commerce locales.
Added a patterns array to each src/locales/*/commerce/product_name.ts
For en locale, for example it’s “{{commerce.productAdjective}} {{commerce.productMaterial}} {{commerce.product}}” preserving the traditional “Tasty Granite Socks”
This allows for languages where the adjectives typically follow the noun e.g. fr, or rtl languages like he, or languages without spaces like zh_CN.
I am not an expert in all languages so there might be minor mistakes in some locales but it should be better than current version.
Some generations:
```
ar أحذية مجمد رائع
az Ergonomik Rezin Stol
da Ubranded Plastik Sæbe
el Απίστευτο Φρέσκο Τραπέζι
en Practical Plastic Pants
eo populara trikita nomŝildo
es Salchichas Pequeño de Metal
es_MX Tuna Rústico de Soft
fa سالاد تازه خوش طعم
fr Chemise Raffiné en Béton
he עוף כפרי מפלדה
hu Márka nélküli Műanyag Cipő
id_ID Celana Kayu Ramping
lv Mazs plastmasas plāksteris
nl elektrische katoenen zak
pt_BR Teclado Genérico de Concreto
pt_PT Pizza Licenciado de Fresco
ru Интеллектуальный Меховой Компьютер
sv Liten Stål Bil
tr Küçük İpek Kayseri Pastırması
ur خوبصورت کنکریٹ پتلون
uz_UZ_latin Arzon Muzlatilgan Paypoq
zh_CN 钢电子的肥皂
```
matthewmayer
added
p: 1-normal
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3657 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 2995 2995
Lines 236243 236313 +70
Branches 941 939 -2
=======================================
+ Hits 236186 236256 +70
Misses 57 57
🚀 New features to boost your workflow:
|
xDivisionByZerox
approved these changes
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces localized product-name patterns across the commerce locales for
faker.commerce.productName().Added a patterns array to each
src/locales/*/commerce/product_name.tsFor en locale, for example it’s
“{{commerce.productAdjective}} {{commerce.productMaterial}} {{commerce.product}}”preserving the traditional “Tasty Granite Socks”This allows for languages where the adjectives typically follow the noun e.g.
fr, or rtl languages likehe, or languages without spaces likezh_CN.I am not an expert in all languages so there might be minor mistakes in some locales but it should be better than current version. I only added one pattern per language though this gives the flexibility to add more in future if needed.
Some generations: